Skip to content

NO TICKET: implement GET /thing/{thing_id}/deployment#196

Merged
jirhiker merged 2 commits into
stagingfrom
jab-thing-deployment-history
Oct 21, 2025
Merged

NO TICKET: implement GET /thing/{thing_id}/deployment#196
jirhiker merged 2 commits into
stagingfrom
jab-thing-deployment-history

Conversation

@jacob-a-brown

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • The well detail page needs to be able to display all sensors that have been deployed at that well

How

Implementation summary - the following was changed / added / removed:

  • Return a list of all deployments at a well

Notes

Any special considerations, workarounds, or follow-up work to note?

  • The endpoint works by getting all deployments at a well. It eagerly loads the sensor for each deployment to avoid N+1 problems. Do we want to proceed through the deployment table, or does it make sense to go through the sensor table?
    • If we go through the sensor table I can return a list of sensors and their deployment history, though I'd need to put in a little of extra work to ensure that the deployment history only pertains to the appropriate well

@codecov-commenter

codecov-commenter commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
api/thing.py 98.61% <100.00%> (ø)
db/deployment.py 100.00% <100.00%> (ø)
schemas/deployment.py 100.00% <100.00%> (ø)
tests/test_thing.py 100.00% <100.00%> (ø)

@TylerAdamMartinez TylerAdamMartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jirhiker jirhiker merged commit 43bc740 into staging Oct 21, 2025
3 checks passed
@jirhiker jirhiker deleted the jab-thing-deployment-history branch October 21, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants